Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cron jobs #934

Merged
merged 77 commits into from
Aug 31, 2022
Merged

Add cron jobs #934

merged 77 commits into from
Aug 31, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented May 20, 2022 •
edited by anbraten
Loading

TODOs

Backend

Frontend

  • add ui
  • mention time is in UTC
  • Set clock-icon as avatar if cron task
  • hide refs/heads/ part in build-list-view as done with others

CLI

  • extend client sdk
  • add cli subcomand
  • ls works
  • add works
  • update works
  • info works
  • rm works

Docs

  • add docs
  • mention default event filter (push, tag, pull, deploy)

Tests

  • unit tests
  • integration tests

Related refs

Follow UP

  • Button to trigger a run now

close #8

6543
6543 commented May 20, 2022
View reviewed changes
server/model/cron_job.go Outdated Show resolved Hide resolved
@mscherer

This comment was marked as resolved.

Sign in to view
@6543 6543 force-pushed the add-cron-jobs branch from 0211c68 to 59d5514 Compare June 1, 2022 15:34
@6543 6543 changed the title Braindump: Add cron jobs WIP: Add cron jobs Jun 1, 2022
@6543 6543 added feature add new functionality wip labels Jun 1, 2022
@6543 6543 added this to the 1.0.0 milestone Jun 1, 2022
@6543 6543 mentioned this pull request Jun 2, 2022
Merged
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022 •
edited
Loading

Codecov Report

Merging #934 (358384f) into master (08a9915) will decrease coverage by 1.02%.
The diff coverage is 16.41%.

@@            Coverage Diff             @@
##           master     #934      +/-   ##
==========================================
- Coverage   50.40%   49.38%   -1.03%     
==========================================
  Files          83       86       +3     
  Lines        6341     6535     +194     
==========================================
+ Hits         3196     3227      +31     
- Misses       2959     3120     +161     
- Partials      186      188       +2
Impacted Files Coverage Δ
server/model/build.go 0.00% <ø> (ø)
server/model/cron.go 0.00% <0.00%> (ø)
server/remote/bitbucket/bitbucket.go 85.71% <0.00%> (-1.17%) ⬇️
server/remote/bitbucketserver/bitbucketserver.go 0.00% <0.00%> (ø)
server/remote/coding/coding.go 62.96% <0.00%> (-0.89%) ⬇️
server/remote/gitea/gitea.go 34.27% <0.00%> (-1.42%) ⬇️
server/remote/github/github.go 15.30% <0.00%> (-0.42%) ⬇️
server/remote/gitlab/gitlab.go 22.43% <0.00%> (-0.88%) ⬇️
server/remote/gogs/gogs.go 50.23% <0.00%> (-2.50%) ⬇️
server/store/datastore/migration/migration.go 37.50% <ø> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anbraten anbraten mentioned this pull request Jul 1, 2022
Closed
31 tasks
This was referenced Jul 8, 2022
Closed
Closed
@6543 6543 requested a review from anbraten August 31, 2022 14:24
@6543 6543 requested a review from qwerty287 August 31, 2022 14:30
anbraten
anbraten reviewed Aug 31, 2022
View reviewed changes
server/cron/cron.go Outdated Show resolved Hide resolved
server/model/cron.go Outdated Show resolved Hide resolved
server/store/datastore/cron.go Outdated Show resolved Hide resolved
server/store/datastore/cron.go Outdated Show resolved Hide resolved
server/store/datastore/cron.go Outdated Show resolved Hide resolved
server/store/datastore/cron.go Outdated Show resolved Hide resolved
server/store/datastore/cron.go Outdated Show resolved Hide resolved
server/store/datastore/cron.go Outdated Show resolved Hide resolved
web/src/components/repo/build/BuildItem.vue Show resolved Hide resolved
6543
6543 commented Aug 31, 2022
View reviewed changes
server/store/datastore/cron.go Outdated Show resolved Hide resolved
6543
6543 commented Aug 31, 2022
View reviewed changes
server/store/datastore/cron.go Outdated Show resolved Hide resolved
6543
6543 commented Aug 31, 2022
View reviewed changes
server/store/datastore/cron.go Outdated Show resolved Hide resolved
6543
6543 commented Aug 31, 2022
View reviewed changes
server/store/datastore/cron.go Outdated Show resolved Hide resolved
@6543 @anbraten
Apply suggestions from code review
ac1a551 
Co-authored-by: Anbraten <anton@ju60.de>
6543
6543 commented Aug 31, 2022
View reviewed changes
server/store/datastore/cron.go Outdated Show resolved Hide resolved
6543
6543 commented Aug 31, 2022
View reviewed changes
server/store/datastore/cron.go Outdated Show resolved Hide resolved
anbraten
anbraten reviewed Aug 31, 2022
View reviewed changes
server/api/cron.go Outdated Show resolved Hide resolved
6543
6543 commented Aug 31, 2022
View reviewed changes
server/store/datastore/cron.go Outdated Show resolved Hide resolved
6543
6543 commented Aug 31, 2022
View reviewed changes
server/store/datastore/cron.go Outdated Show resolved Hide resolved
qwerty287
qwerty287 reviewed Aug 31, 2022
View reviewed changes
server/model/build.go Outdated Show resolved Hide resolved
@anbraten @qwerty287
Update server/model/build.go
4e5c1c4 
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
qwerty287
qwerty287 approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@qwerty287 qwerty287 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't find typos otherwise :)

@6543 6543 requested a review from anbraten August 31, 2022 16:28
@6543 6543 merged commit 383f273 into woodpecker-ci:master Aug 31, 2022
@6543 6543 deleted the add-cron-jobs branch August 31, 2022 22:36
@6543 6543 mentioned this pull request Sep 1, 2022
Closed
@anbraten anbraten mentioned this pull request Nov 26, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

@anbraten anbraten Awaiting requested review from anbraten

Assignees
No one assigned
Labels
feature add new functionality
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Cron triggers
8 participants
@6543 @mscherer @codecov-commenter @UnlimitedCookies @anbraten @woodpecker-bot @kdumontnu @qwerty287